Skip to content

fix: view shared devices#200

Merged
incognitojam merged 20 commits intomasterfrom
shared-device
Mar 28, 2025
Merged

fix: view shared devices#200
incognitojam merged 20 commits intomasterfrom
shared-device

Conversation

@incognitojam
Copy link
Copy Markdown
Collaborator

@incognitojam incognitojam commented Feb 28, 2025 •
edited
Loading

use test cases to validate redirect to login page and to view shared devices/public routes!

  • you can view other devices even when you don't own them or are not signed in
  • you can view public routes

⚠️ video does not load for shared routes, yet

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 5, 2025 •
edited
Loading

deployed preview: https://200.connect-d5y.pages.dev

Welcome to connect! Make sure to:

  • read the contributing guidelines
  • mark your PR as a draft until it's ready to review
  • post the preview on Discord; feedback from users will speedup the PR review

Mobile

Desktop

@incognitojam incognitojam force-pushed the shared-device branch 4 times, most recently from 18bc1fe to c0616f7 Compare March 24, 2025 01:09
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 24, 2025 •
edited
Loading

Changes:

path lines diff
./api/devices.ts 104 +29
./App.browser.test.tsx 40 +14
./pages/dashboard/Dashboard.tsx 149 +11
./pages/dashboard/activities/DeviceActivity.tsx 163 +3
./api/route.ts 37 +3
./components/material/Icon.tsx 35 +1

Total lines: 4330 (+61)

@incognitojam incognitojam force-pushed the shared-device branch 2 times, most recently from 93a970c to 21cb7a0 Compare March 28, 2025 11:44
@incognitojam incognitojam added the bugfix fixes an issue label Mar 28, 2025
@incognitojam incognitojam force-pushed the shared-device branch 2 times, most recently from 1a16b98 to aa735b8 Compare March 28, 2025 16:16
@incognitojam incognitojam added the CI / testing unit tests, CI, etc. label Mar 28, 2025
@incognitojam incognitojam changed the title fix viewing shared devices/public routes [wip] fix: view shared devices Mar 28, 2025
@incognitojam incognitojam marked this pull request as ready for review March 28, 2025 19:20
@incognitojam incognitojam merged commit 1b7ec43 into master Mar 28, 2025
7 checks passed
@incognitojam incognitojam deleted the shared-device branch March 28, 2025 20:36
@sshane
Copy link
Copy Markdown
Contributor

sshane commented Mar 29, 2025 •
edited
Loading

@incognitojam this broke drive stats and commaai/connect#291

@incognitojam
Copy link
Copy Markdown
Collaborator Author

incognitojam commented Mar 29, 2025

ah sorry, I think it affects read-only users though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bugfix fixes an issue CI / testing unit tests, CI, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@incognitojam @sshane